Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: "list all replies" button click issue #25

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

abirc8010
Copy link
Contributor

Issue(s)

Fixes #24

Acceptance Criteria fulfillment

  • All buttons function properly even when the 'List All Replies' is clicked.

Proposed changes (including videos or screenshots)

fix.webm

@abirc8010
Copy link
Contributor Author

abirc8010 commented Jan 4, 2025

Hey @VipinDevelops I have considered removing RoomInteraction.clearInteractionRoomId() and apparently everything seems to work fine , I would like to know your thoughts on this or do I need to try a different approach?

@VipinDevelops
Copy link
Collaborator

Hey @VipinDevelops I have considered removing RoomInteraction.clearInteractionRoomId() and apparently everything seems to work fine , I would like to know your thoughts on this or do I need to try a different approach?

Thanks for PR @abirc8010 I will test in locally and let you know

Copy link
Collaborator

@VipinDevelops VipinDevelops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@VipinDevelops VipinDevelops merged commit 0c366e2 into RocketChat:main Feb 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: buttons does not work after clicking 'List all Replies'
2 participants