-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Quoting issues #641
base: develop
Are you sure you want to change the base?
Fix: Quoting issues #641
Conversation
476e3eb
to
cec61ca
Compare
Hey @Spiral-Memory, I have implemented recursive and multiple quoting in EmbeddedChat, can you please review it? |
Let me know once you check the deployment of this pull request |
Sure @devanshkansagra |
Ok |
Hey @Spiral-Memory, could you please approve to test so that can come to know whether the changes I made in this pr gets deployed properly and we can prevent the situation before we faced and we had to revert the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to test ! Review pending
Okay |
@Spiral-Memory, it is again facing the same error in deployment like earlier, but I am also confused that it is working properly in my local development environment but it is failing in the production build |
But as far as i can see, build succeeded |
yea build is succeded but when I checked the logs, it issues is in the build part only |
Share me the error |
the above image is the error |
preview.mjs:401 TypeError: Cannot read properties of undefined (reading '0') |
the above is the console error |
1f1b60f
to
7cf2da1
Compare
Hey @Spiral-Memory, can you please approve again to test, coz I have added some checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to test ! Review pending
it is now working well |
you can test it |
Hey @Spiral-Memory, I have tested from my side, it is working well, you can also test and review the code and output |
@devanshkansagra Please resolve the conflicts |
7cf2da1
to
0548820
Compare
Hey @Spiral-Memory, can you review the pr and also approve to test after to check whether everything is well |
Hey @Spiral-Memory, you can test the deployment and suggest any changes |
I'll test / review it and let you know |
Acceptance Criteria fulfillment
Fixes #640
Video/Screenshots
Screencast.from.04-11-24.10.14.00.PM.IST.webm
PR Test Details
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-641/ after approval.