Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Mention Rendering Issue in File Upload Descriptions #649

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix: Mention Rendering Issue in File Upload Descriptions #649

wants to merge 2 commits into from
+135 −17

Conversation

SinghaAnirban005
Copy link
Contributor

@SinghaAnirban005 SinghaAnirban005 commented Oct 30, 2024 •
edited
Loading

Brief Title

Fix Mention Rendering Issue in File Upload Descriptions

Acceptance Criteria fulfillment

  • Ensure that mentions (e.g., @username) in File Upload descriptions render with highlighted styling, matching the styling used in messages.
  • Verify that when the current user's username is mentioned in the description, it applies a distinct background color

Fixes #648
Closes #622

Video/Screenshots

After making necessary changes
Screenshot 2024-10-30 224954

PR Test Details

Implemented regex on the description's before they render and ensured that list of members appear on typing "@" in the description box

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-<pr_number> after approval.

@CLAassistant
Copy link

CLAassistant commented Oct 30, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Spiral-Memory
Copy link
Collaborator

Thank you so much for the contribution @SinghaAnirban005

Please run prettier formatter and ensure that your code follows the linting rules.

@devanshkansagra
Copy link
Contributor

@Spiral-Memory can you please approve the changes so that I can test it live

@Spiral-Memory
Copy link
Collaborator

Actually, I'm not sure whether we need this. I may need to have a discussion to understand it better.

@devanshkansagra
Copy link
Contributor

okay then when you are available we will disscuss

@devanshkansagra
Copy link
Contributor

Hey @SinghaAnirban005, can you share the video of this implementation so that I can check it visually?

@SinghaAnirban005
Copy link
Contributor Author

@devanshkansagra

Case when user mentions himself in description of an attachment

EmbeddedChat._.Simple.-.Simple.Storybook.-.Brave.2024-11-05.12-00-19.mp4

Case when user mentions other members in group

EmbeddedChat._.Simple.-.Simple.Storybook.-.Brave.2024-11-05.12-01-21.mp4

@devanshkansagra
Copy link
Contributor

Hey @SinghaAnirban005, it looks good, but one thing to ask, does it displays the user profile when clicked on the mentioned user?

This gets displayed in Rocketchat

@SinghaAnirban005
Copy link
Contributor Author

@devanshkansagra it does not !!
Should i create a new issue template for that or improvise in the same PR

@Spiral-Memory
Copy link
Collaborator

Wait wait @SinghaAnirban005
I'll review and let you know..

@devanshkansagra
Copy link
Contributor

No no, work in this only no need to create new issue

@SinghaAnirban005
Copy link
Contributor Author

@Spiral-Memory okay !!

@Spiral-Memory
Copy link
Collaborator

@SinghaAnirban005,
A suggestion for you: I feel a lot of the code changes are unnecessary in your PRs. You can implement similar features with far fewer changes. Try leveraging React’s capabilities instead of handling so many things manually.

@SinghaAnirban005
Copy link
Contributor Author

@Spiral-Memory Thank you for your suggestions !! Will definitely refine my approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@SinghaAnirban005 @CLAassistant @Spiral-Memory @devanshkansagra