Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Contextual bar elements always return wrong roomID for action handler #788

Open
RyanbowZ opened this issue Jul 28, 2024 · 1 comment

Comments

@RyanbowZ
Copy link

When adding an element (e.g. a button) on a contextual bar, it will set some Action IDs, and then the executeActionHandler is expected to handle the action when the element is triggered and process it according to that ID.
But in code implementation, despite that element is triggered, the room id get by this handler is wrong, which is just the general room rather than the room that the contextual bar was in.

Current temporary solution: from @vipin.chaudhary and @zishan.ahmad
When you open the contextual bar it's opening in correct room mean the action you are using to open the room get's the correct I'd but when you make a action handler it's getting the general room
The fix for this one is when you do a action to open the contextual bar just store the roomId in persistence for each user.
And when you need to perform an action use that stored room I'd to get the room info using room reader
When you are done just remove the persistence.

@scuciatto
Copy link
Member

Hello, @RyanbowZ. I believe this is not a bug on the apps-engine. Looks like the request of the ui.interaction is being sent without the rid param so, the apps-engine doing a findOne() that returns general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants