fix: "Status" column values in "Custom Status" page table not translated #34857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 3d8bb2b The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gabriellsh
changed the title
gabriellsh
previously requested changes
Dec 31, 2024
Co-authored-by: gabriellsh <[email protected]>
tassoevan
previously approved these changes
Dec 31, 2024
yash-rajpal
approved these changes
Dec 31, 2024
|
Sir, I'm not an expert in this, but are these errors during the merge happening with every PR, or could there be another issue causing them ? |
AyushKumar123456789
requested review from
tassoevan,
gabriellsh and
yash-rajpal
yash-rajpal
approved these changes
Jan 8, 2025
yash-rajpal
dismissed
gabriellsh’s stale review
Applies Gabriel's suggestions.
yash-rajpal
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
KevLehman
removed
the
stat: ready to merge
dionisio-bot
bot
added
the
stat: ready to merge
dougfabris
requested changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Closes #34856
CORE-910
Steps to test or reproduce
Before :
Custom.user.status.presence.not.translated.mp4
After :
Further comments