Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rcocketcat complains about %s mongo version. #34862

Open
florisvangeel opened this issue Jan 2, 2025 · 7 comments
Open

Rcocketcat complains about %s mongo version. #34862

florisvangeel opened this issue Jan 2, 2025 · 7 comments
Labels
Tasked Added to the internal issue tracking

Comments

@florisvangeel
Copy link

florisvangeel commented Jan 2, 2025

Description:

Rocket cat should know my mongo version,

Steps to reproduce:

  1. Install mongo 6.x from package manager for desired OS.
  2. Build rocket chat tag/7.1.0 from source.

Expected behavior:

Rocket cat should read i'm running 5.x and not nag

Actual behavior:

Rocket cat is nagging about %s version.

carnag.mp4

Server Setup Information:

  • Version of Rocket.Chat Server: 7.1.0
  • License Type: Community
  • Number of Users: 1
  • Operating System: Ubuntu 20.04
  • Deployment Method: ansible
  • Number of Running Instances:1
  • DB Replicaset Oplog: / wiredTiger (oplog Enabled)
  • NodeJS Version: v20.17.0
  • MongoDB Version: 5.0.30

Client Setup Information

  • Desktop App or Browser Version: Chrome latest stable
  • Operating System: OSX

Additional context

Please make rocket.cat smarter, i like this cat.

Relevant logs:

N.A.

@florisvangeel
Copy link
Author

florisvangeel commented Jan 2, 2025

Screenshot 2025-01-02 at 03 07 52 docs say this version should be supported but depricated? then it should nag me how to upgrade to 6 or 7 not make me lost in this doc..

@Swayam-code
Copy link

Hey @florisvangeel , I can take this issue. The problem here is that Rocket.cat incorrectly nags the user about a supported but deprecated MongoDB version (5.x), causing confusion. According to the documentation, version 5.x should be marked as deprecated but not unsupported.

I’ll update the logic for Rocket.cat’s version validation to check for deprecated versions and provide helpful guidance (e.g., steps to upgrade to 6.x or 7.x) instead of issuing unsupported warnings. This will align Rocket.cat’s behavior with the documentation and improve user clarity.

I'll be grateful if you assign this to me.

@reetp
Copy link

reetp commented Jan 3, 2025

I'll be grateful if you assign this to me.

No one assigns issues.

https://gist.github.com/reetp/b0ba4e3d0ea2ff48ca9da00a5a647d42#github

If you want to work on something ask in open.rocket.chat in the support channel before starting.

N.B. There are already issues around this IIRC.

I'll look more week & speak to Casals. Likely the team will handle this.

@casalsgh
Copy link
Contributor

casalsgh commented Jan 3, 2025

asking the team to check. Thanks for reporting

@reetp reetp added the Tasked Added to the internal issue tracking label Jan 5, 2025
@Gustrb
Copy link
Contributor

Gustrb commented Jan 6, 2025

I don't have any problem with Rocket.cat nagging if you are using a deprecated version (even if we support it). We could reword the sentence, so the user understands that the Mongo version will be deprecated on the next major, but besides that I think the behavior is correct.
(we should not show a %s though)

@reetp
Copy link

reetp commented Jan 6, 2025

We could reword the sentence,

Yup - it is terrible right now!

(we should not show a %s though)

Absolutely - that annoying bug has been hanging round like a bad smell for some time. Just looks unprofessional.

@florisvangeel
Copy link
Author

florisvangeel commented Jan 21, 2025

According to the documentation my mongo is deprecated but still working/supported.

~# mongod --version
db version v5.0.22
Build Info: {
    "version": "5.0.22",
        "target_arch": "x86_64"
    }
}

if there would be certain versions of 5.x not supported the docs should reflect this.
else if 5.x is depricated as the docs state rocket.cat should help me upgrade, not nag about it.
else the messages and link should be clear for the workspace maintainer to follow up.
Notice the link to go.rocket.chat/i/suppoted-versions doesn't give a status 200 anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tasked Added to the internal issue tracking
Projects
None yet
Development

No branches or pull requests

5 participants