BUG: issues with encoding and null field updates (#60)

Co-authored-by: Gabriel Barberini <[email protected]>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

Author: 3 people

requirements.txt

@@ -9,7 +9,7 @@ pymongo
 jsonpickle
 gunicorn
 uvicorn
-rocketpy
+git+https://github.com/RocketPy-Team/RocketPy.git@develop
 uptrace
 opentelemetry.instrumentation.fastapi
 opentelemetry.instrumentation.requests

src/repositories/motor.py

@@ -28,7 +28,7 @@ async def read_motor_by_id(self, motor_id: str) -> Optional[MotorModel]:
     @repository_exception_handler
     async def update_motor_by_id(self, motor_id: str, motor: MotorModel):
         await self.update_by_id(
-            motor.model_dump(exclude_none=True), data_id=motor_id
+            motor.model_dump(exclude_none=False), data_id=motor_id
         )
 
     @repository_exception_handler

src/repositories/rocket.py

@@ -28,7 +28,7 @@ async def read_rocket_by_id(self, rocket_id: str) -> Optional[RocketModel]:
     @repository_exception_handler
     async def update_rocket_by_id(self, rocket_id: str, rocket: RocketModel):
         await self.update_by_id(
-            rocket.model_dump(exclude_none=True), data_id=rocket_id
+            rocket.model_dump(exclude_none=False), data_id=rocket_id
         )
 
     @repository_exception_handler

src/utils.py

@@ -55,26 +55,28 @@ def for_flight(cls) -> 'DiscretizeConfig':
 
 class InfinityEncoder(RocketPyEncoder):
     def default(self, o):
-        obj = o
         if (
-            isinstance(obj, Function)
-            and not callable(obj.source)
-            and obj.__dom_dim__ == 1
+            isinstance(o, Function)
+            and not callable(o.source)
+            and o.__dom_dim__ == 1
         ):
-            size = len(obj._domain)
+            size = len(o._domain)
             reduction_factor = 1
             if size > 25:
                 reduction_factor = size // 25
             if reduction_factor > 1:
-                obj = obj.set_discrete(
-                    obj.x_array[0],
-                    obj.x_array[-1],
+                o = o.set_discrete(
+                    o.x_array[0],
+                    o.x_array[-1],
                     size // reduction_factor,
                     mutate_self=False,
                 )
-        if isinstance(obj, Flight):
-            obj._Flight__evaluate_post_process()
-            solution = np.array(obj.solution)
+        if isinstance(o, Flight):
+            try:
+                o._Flight__evaluate_post_process
+            except Exception:
+                pass
+            solution = np.array(o.solution)
             size = len(solution)
             if size > 25:
                 reduction_factor = size // 25
@@ -88,12 +90,12 @@ def default(self, o):
                     reduced_solution[:, i] = interp1d(
                         solution[:, 0], col, assume_sorted=True
                     )(reduced_scale)
-                obj.solution = reduced_solution.tolist()
+                o.solution = reduced_solution.tolist()
 
-            obj.flight_phases = None
-            obj.function_evaluations = None
+            o.flight_phases = None
+            o.function_evaluations = None
 
-        return super().default(obj)
+        return super().default(o)
 
 
 def rocketpy_encoder(obj):

src/views/environment.py

@@ -43,7 +43,7 @@ class EnvironmentSimulation(ApiBaseView):
     initial_east: Optional[float] = None
     initial_hemisphere: Optional[str] = None
     initial_ew: Optional[str] = None
-    max_expected_height: Optional[int] = None
+    max_expected_height: Optional[float] = None
     date: Optional[datetime] = Field(default_factory=_default_future_datetime)
     local_date: Optional[datetime] = Field(
         default_factory=_default_future_datetime