Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 'initial_solution' parameter in Flight class #29

Open
coderabbitai bot opened this issue Sep 15, 2024 · 5 comments
Open

Implement 'initial_solution' parameter in Flight class #29

coderabbitai bot opened this issue Sep 15, 2024 · 5 comments
Assignees

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 15, 2024

We need to implement the initial_solution init parameter for the Flight class, as noted in the TODO comment in lib/models/flight.py.

Reference PR: #25
Reference comment: #25 (comment)

Requested by @GabrielBarberini.

@finnmezz
Copy link

finnmezz commented Mar 4, 2025

Hi, I was just wondering how this was going? I am struggling to be able to use initial_solution to input initial values. I try to input values but it does seem to get anywhere, it either takes too long, outputs NaN values or says indexing isn't working, even when it is very basic values.
Thanks

@Gui-FernandesBR
Copy link
Member

Hi, I was just wondering how this was going? I am struggling to be able to use initial_solution to input initial values. I try to input values but it does seem to get anywhere, it either takes too long, outputs NaN values or says indexing isn't working, even when it is very basic values.
Thanks

@finnmezz can you confirm you really meant to open this issue on Infinity (a rest API) rather than RocketPy library itself?

@finnmezz
Copy link

finnmezz commented Mar 4, 2025

Hi @Gui-FernandesBR , I'm not sure what Infinity API is, but essentially yes, just the RocketPy library. I thought I'd ask on this one since it looked like someone had started to try and implement it.
But yeah, I'm having trouble implementing initial conditions with any values other than 0 and 1 that give good results.
Thanks

@Gui-FernandesBR
Copy link
Member

Hi @Gui-FernandesBR , I'm not sure what Infinity API is, but essentially yes, just the RocketPy library. I thought I'd ask on this one since it looked like someone had started to try and implement it. But yeah, I'm having trouble implementing initial conditions with any values other than 0 and 1 that give good results. Thanks

This repository is not the house for the rocketpy library.

The initial_solution parameter is already implemented in the lib since v0! I recommend reading the documentation carefully here: https://docs.rocketpy.org/en/latest/reference/classes/Flight.html#rocketpy.Flight.__init__

If your error persists, we welcome you to raise a question at our main repo: https://github.com/RocketPy-Team/RocketPy.
Discord is also an option.

When asking a question, I recommend commenting your code (without sensitive information, of course), and an illustration of what error exactly you're facing.

@Gui-FernandesBR
Copy link
Member

I'm closing this issue since it is not related to the rest API itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants