Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Individual Fin #686

Closed
wants to merge 5 commits into from
Closed

ENH: Individual Fin #686

wants to merge 5 commits into from

Conversation

MateusStano
Copy link
Member

@MateusStano MateusStano commented Sep 11, 2024 •
edited by juliomachad0
Loading

Pull request type

  • Code changes (bugfix, features)

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Description

Individual fins have been added to RocketPy:

  • Fin class, TrapezoidalFin class and EllipsoidalFin class have been added
  • A simulation with a fin set is equivalent to building a fin set with individual fins in the correct positions. There are only small differences in roll dynamics, since the roll moment comes directly from the lift force, instead of going through barrowman's calculations of the roll coefficient

Breaking change

  • Yes
  • No

Remaining Tasks

  • 1. Add a representation of IndividualFin in the Drawing.
  • 2. Create Plots and Prints classes for IndividualFin
  • 3. Fix stability margin calculation for IndividualFin. Add lateral stability analysis. Or add warning saying stability calculations
    will not work for IndividualFins
  • 3. Pylint
  • 4. Tests
  • 5. Class usage page / example usage
  • 6. Example usage with controllers

It would be truly great to get some help on these minor tasks

Contributors

Special thanks to @kevin-alcaniz and Faraday Rocketry UPV for their contributions!!

@MateusStano MateusStano added Enhancement New feature or request, including adjustments in current codes Aerodynamics Any problem to be worked on top of RocketPy's Aerodynamic labels Sep 11, 2024
@MateusStano MateusStano requested a review from a team as a code owner September 11, 2024 12:09
@MateusStano MateusStano changed the base branch from develop to enh/generic-surfaces September 11, 2024 12:09
@codecov Codecov
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 28.98089% with 223 lines in your changes missing coverage. Please review.

Project coverage is 72.26%. Comparing base (1f2358a) to head (9e7d708).
Report is 46 commits behind head on enh/generic-surfaces.

Files with missing lines Patch % Lines
rocketpy/rocket/aero_surface/fins/fin.py 31.46% 98 Missing ⚠️
...cketpy/rocket/aero_surface/fins/trapezoidal_fin.py 23.40% 72 Missing ⚠️
...ocketpy/rocket/aero_surface/fins/elliptical_fin.py 17.64% 42 Missing ⚠️
rocketpy/rocket/rocket.py 38.88% 11 Missing ⚠️
Additional details and impacted files 
@@                   Coverage Diff                    @@
##           enh/generic-surfaces     #686      +/-   ##
========================================================
- Coverage                 74.91%   72.26%   -2.65%     
========================================================
  Files                        87       94       +7     
  Lines                     10308    10899     +591     
========================================================
+ Hits                       7722     7876     +154     
- Misses                     2586     3023     +437

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gui-FernandesBR Gui-FernandesBR marked this pull request as draft September 16, 2024 00:12
Base automatically changed from enh/generic-surfaces to develop September 21, 2024 19:36
@Gui-FernandesBR
Copy link
Member

Must be re-opened in the future

@Gui-FernandesBR Gui-FernandesBR linked an issue Dec 8, 2024 that may be closed by this pull request
ENH: Add single fin #666
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MateusStano MateusStano

Labels
Aerodynamics Any problem to be worked on top of RocketPy's Aerodynamic Enhancement New feature or request, including adjustments in current codes
Projects
LibDev Roadmap
Status: Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ENH: Add single fin
3 participants
@MateusStano @Gui-FernandesBR @juliomachad0