Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Feature/osw debug files #136

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

Conversation

singjc
Copy link
Collaborator

@singjc singjc commented Jun 3, 2024

In Draft

TODOs

  • implement as part of GUI
  • add unit tests
  • add/update documentation

Description

Implement feature to visualize calibration debug files from OpenSwath

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Example

image

image

image

How Has This Been Tested?

  • Locally via jupyter notebook

Test Configuration:

  • Firmware version: popOS
  • Hardware:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@singjc singjc added the enhancement New feature or request label Jun 3, 2024
@singjc singjc linked an issue Jun 3, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEATURE: OpenSwath debug file visualizations
1 participant