Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot Interface Refactoring #62

Open
jcharkow opened this issue Jan 3, 2024 · 3 comments
Open

Plot Interface Refactoring #62

jcharkow opened this issue Jan 3, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request later address this issue at a later time refactor Refactoring code

Comments

@jcharkow
Copy link
Collaborator

jcharkow commented Jan 3, 2024

Refactor plotting documentation for easier interaction with python interface/jupyter notebook interface. I am not too sure which strategy would be best.

Some ideas:

Remove the config interface and directly take in parameters on initiation.

plotting methods directly built into structs?

@jcharkow jcharkow added enhancement New feature or request refactor Refactoring code later address this issue at a later time labels Jan 3, 2024
@singjc
Copy link
Collaborator

singjc commented Jan 3, 2024

I kind of like the config interface to avoid having too many parameters in the method call, unless we use **kwargs to pass parameters directly to the plotting (bokeh figure/ plotly figure) interfaces (which may be limited).

I like the idea of having the plotting methods also directly part of the structs.

@jcharkow
Copy link
Collaborator Author

jcharkow commented Jan 3, 2024

I don't mind the config its just don't really like how some parameters are not relevant for certain plots. Maybe the plot config should be directly parameters of the respective plotters? not a general thing? I am not sure will have to think about it more

@jcharkow jcharkow self-assigned this Feb 27, 2024
@jcharkow
Copy link
Collaborator Author

Some refactoring was done in the #106 More refactoring might need to be done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request later address this issue at a later time refactor Refactoring code
Projects
None yet
Development

No branches or pull requests

2 participants