Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version 6.0 incompatible with Tweakeroo/Carpet accurateblockplacement #29

Open
MeeniMc opened this issue Jun 10, 2023 · 1 comment

Comments

@MeeniMc
Copy link

MeeniMc commented Jun 10, 2023

When the new version of this mod is present, the accurateblockplacement feature of Tweakeroo is broken.

Replication steps:

  1. get an observer
  2. enable accurateblockplacement=yes in tweakeroo config
  3. use the hotkey (default alt) to have the block placement overlay show
  4. place a block with a non-default orientation
  5. the block is placed with default orientation (bug)

Remove mod, this works correctly.

Log item

The log item clearly indicates taht this is due to using @Redirect, maybe a simple fix is to use @Inject at HEAD instead.

08:09:10] [Render thread/WARN] (FabricLoader/Mixin) @Redirect conflict. Skipping mixins.tweakeroo.json:MixinMinecraftClient from mod tweakeroo->@Redirect::onProcessRightClickBlock(Lnet/minecraft/class_636;Lnet/minecraft/class_746;Lnet/minecraft/class_1268;Lnet/minecraft/class_3965;)Lnet/minecraft/class_1269; with priority 990, already redirected by cleancut.mixins.json:MinecraftClientMixin from mod cleancut->@Redirect::onItemUse(Lnet/minecraft/class_636;Lnet/minecraft/class_746;Lnet/minecraft/class_1268;Lnet/minecraft/class_3965;)Lnet/minecraft/class_1269; with priority 1000

versions

	- carpet 1.4.101+v230319
	- carpet-extra 1.4.100
	- cleancut 6.0
	- creativeonepunch 1.3
	- fabric-api 0.83.0+1.19.4
	- malilib 0.15.4
	- tweakeroo 0.16.0
@Ametsuchiru
Copy link
Contributor

Inject at HEAD won't work, that's not how the method works, but i'll try to find a different way to avoid this conflict ^_^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants