Out-of-bounds string read in SettingsDialog

[jgcodes2020]

Trying to open settings (Ctrl+T) causes an error at line 362, apparently during a call to QString::operator[].

RMG/Source/RMG/UserInterface/Dialog/SettingsDialog.cpp

Lines 355 to 367 in 69c24b9

	for (const auto &p : this->pluginList)
	{
	index = ((int)p.Type - 1);
	comboBox = comboBoxArray[index];
	comboBox->addItem(QString::fromStdString(p.Name), QString::fromStdString(p.File));
	if (pluginFileName[index] == QString::fromStdString(p.File))
	{
	comboBox->setCurrentText(QString::fromStdString(p.Name));
	pluginFound[index] = true;
	}
	}

As far as I can tell, pluginFileNames is supposed to be an array of QString, so I have no idea what's going on.

[Rosalie241]

That's a nice catch, it's supposed to be

if (pluginFileNames[index] == QString::fromStdString(p.File))

I copy pasted some code from the commonPluginSettings function, which did things slightly differently.

I'll try to push the fix as soon as I'm on my desktop again ❤️

[Rosalie241]

Fixed it with 37839b0, I'll include it in the next release, thank you for reporting! ❤️