Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Theme not working anymore #11

Open
heinquoi opened this issue Sep 25, 2021 · 7 comments
Open

Dark Theme not working anymore #11

heinquoi opened this issue Sep 25, 2021 · 7 comments

Comments

@heinquoi
Copy link

Hello,
First, thank you very much for this great work !
I enjoyed your Dark Theme (windows 10) until about 1 month ago, when Zotero released the beta version with built-in PDF reader.
After the update, it went back to the usual popping white. I replaced the old userChrome.css with your last release fixed for the 5.0.97 beta version but nothing happened after restart.
Do have any idea of something to do or change to make it work again ?

@Rosmaninho
Copy link
Owner

Uh, weird. It should work. Do you have the Beta version installed side by side with the release version?
Does it have a distinct profile folder?

@heinquoi
Copy link
Author

Hi,
Thank you for your reply !
No I only have the Beta version.
I thought I may have messed up with my Profile or something, so I tried something : completely unistalled Zotero (including associated data & config), and reinstalled it. First thing I did after this reset was creating a chrome folder in the right place and put your css in it.
It still doesn't work.
Here is a screenshot of the Error console of Zotero after that, screenshot taken just after stating Zotero. Many lines show : "Selector expected. Ruleset ignored due to bad selector", then pointing at a line in the userChrome CSS file.
I don't know what it means.
SreenShot Zotero Error Console

@splitt3r
Copy link

splitt3r commented Oct 8, 2021

@Rosmaninho i'm using the beta version of Zotero with the fixes from your last commit. Everything looks great except for the window title bar which is white. Could you give me a hint which class made it dark before?

Awesome work from you ❤️ i think sth. like SASS would make your themes source code more readable. That way others could contribute easier.

@Rosmaninho
Copy link
Owner

The window title bar is an unrelated change in the Windows registry!
https://winaero.com/enable-dark-title-bars-custom-accent-color-windows-10/
https://winaero.com/get-colored-title-bars-in-windows-10/

@Rosmaninho
Copy link
Owner

Hi, Thank you for your reply ! No I only have the Beta version. I thought I may have messed up with my Profile or something, so I tried something : completely unistalled Zotero (including associated data & config), and reinstalled it. First thing I did after this reset was creating a chrome folder in the right place and put your css in it. It still doesn't work. Here is a screenshot of the Error console of Zotero after that, screenshot taken just after stating Zotero. Many lines show : "Selector expected. Ruleset ignored due to bad selector", then pointing at a line in the userChrome CSS file. I don't know what it means.

Zotero is under heavy development and they are changing a lot of their code currently. I need to see what I get when I get a stable version. Running after the goalposts of development versions is a bit complicated because breakage will happen.

@heinquoi
Copy link
Author

Ok I got it ! Thanks a lot anyway, and looking forward to their next stable version
I hope I can see it dark again when possible :)

@kddjenejfkffksd
Copy link

The window title bar is an unrelated change in the Windows registry! https://winaero.com/enable-dark-title-bars-custom-accent-color-windows-10/ https://winaero.com/get-colored-title-bars-in-windows-10/

Maybe you could add this info in the README?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants