Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve i18n version constraints #1097

Open
tagliala opened this issue Apr 30, 2024 · 1 comment · May be fixed by #1103
Open

Improve i18n version constraints #1097

tagliala opened this issue Apr 30, 2024 · 1 comment · May be fixed by #1103

Comments

@tagliala
Copy link
Contributor

tagliala commented Apr 30, 2024 •
edited
Loading

money/money.gemspec

Line 18 in 37e183a

s.add_dependency 'i18n', [">= 0.6.4", '<= 2']

Probably the first i18n version fully compatible with Ruby 3.0 is v1.8.6.

Ref:
@tagliala
Copy link
Contributor Author

tagliala commented May 2, 2024 •
edited
Loading

Actually:

< 0.8.0

Finished in 0.1731 seconds (files took 0.22427 seconds to load)
510 examples, 95 failures

0.8.0

Finished in 0.16345 seconds (files took 0.21812 seconds to load)
510 examples, 0 failures

tagliala added a commit to tagliala/money that referenced this issue May 31, 2024
@tagliala
Bump Ruby I18n requirement
44d9d3b 
Require 1.9, the first version tested against Ruby 3.1

Close RubyMoney#1097

Ref: https://github.com/ruby-i18n/i18n/releases?page=2
tagliala added a commit to tagliala/money that referenced this issue May 31, 2024
@tagliala
Bump Ruby I18n requirement
e96ad5b 
Require 1.9, the first version tested against Ruby 3.1

Close RubyMoney#1097

Ref: https://github.com/ruby-i18n/i18n/releases?page=2
tagliala added a commit to tagliala/money that referenced this issue May 31, 2024
@tagliala
Bump Ruby I18n requirement
8027f67 
Require 1.9, the first version tested against Ruby 3.1

Close RubyMoney#1097

Ref: https://github.com/ruby-i18n/i18n/releases?page=2
@tagliala tagliala linked a pull request May 31, 2024 that will close this issue
Open
tagliala added a commit to tagliala/money that referenced this issue Jun 4, 2024
@tagliala
Bump Ruby I18n requirement
7fd9ab7 
Require 1.9, the first version tested against Ruby 3.1

Close RubyMoney#1097

Ref: https://github.com/ruby-i18n/i18n/releases?page=2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump Ruby I18n requirement tagliala/money
1 participant
@tagliala