[Feat/signup-validate] - 중복로그인(따닥) 방지

[ekgns33]

작업내역

• 소셜 로그인에 대한 중복 처리 로직 추가
• 회원가입 토큰 삭제 로직 추가
• 테스트 작성

Summary by CodeRabbit

• New Features

  • Improved signup process with explicit checks for existing users and enhanced error handling for invalid or expired tokens.
  • Signup tokens are now removed after successful registration.
  • Added method to check existence of OAuth users by provider ID and social provider.

• Bug Fixes

  • Prevented duplicate user registrations and token reuse during signup.

• Tests

  • Added comprehensive acceptance and unit tests to verify successful signup, token reuse prevention, and duplicate user conflict scenarios.

[coderabbitai]

Walkthrough

The changes introduce new validation and cleanup logic to the signup process, focusing on preventing duplicate user registration and ensuring signup tokens are invalidated after use. Repository interfaces are extended with new methods for existence checks and token deletion. The SignUpUsecaseImpl service now validates user existence before registration and removes the signup token after successful registration. Error handling is improved with domain-specific exceptions. Comprehensive tests are added, including acceptance and service-level tests, to verify successful signup, token reuse prevention, and duplicate user rejection.

Changes

File(s)	Summary
src/main/java/org/runimo/runimo/auth/repository/SignupTokenRepository.java	Added deleteByToken(String token) method to allow deletion of signup tokens by token value.
src/main/java/org/runimo/runimo/auth/service/SignUpUsecaseImpl.java	Updated register method to validate existing users, remove used tokens, and improve error handling.
src/main/java/org/runimo/runimo/user/repository/OAuthInfoRepository.java	Added existsByProviderIdAndProvider method for checking OAuth user existence by provider and ID.
src/main/java/org/runimo/runimo/user/service/UserRegisterService.java	Added dependency on OAuthInfoRepository and new validateExistingUser method for duplicate checks.
src/test/java/org/runimo/runimo/auth/controller/AuthAcceptanceTest.java	New acceptance test class for signup API: tests for success, token reuse failure, and duplicate user.
src/test/java/org/runimo/runimo/auth/service/SignUpUsecaseTest.java	New service-level test class: verifies exception thrown for duplicate user registration attempt.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant SignUpUsecaseImpl
    participant JwtResolver
    participant SignupTokenRepository
    participant UserRegisterService
    participant OAuthInfoRepository

    Client->>SignUpUsecaseImpl: register(command)
    SignUpUsecaseImpl->>JwtResolver: resolveSignupToken(command.token)
    JwtResolver-->>SignUpUsecaseImpl: SignupTokenPayload
    SignUpUsecaseImpl->>SignupTokenRepository: findUnExpiredSignupToken(token)
    SignupTokenRepository-->>SignUpUsecaseImpl: SignupToken
    SignUpUsecaseImpl->>UserRegisterService: validateExistingUser(providerId, socialProvider)
    UserRegisterService->>OAuthInfoRepository: existsByProviderIdAndProvider(providerId, socialProvider)
    OAuthInfoRepository-->>UserRegisterService: Boolean
    UserRegisterService-->>SignUpUsecaseImpl: (throws if exists)
    SignUpUsecaseImpl->>UserRegisterService: registerUser(...)
    UserRegisterService-->>SignUpUsecaseImpl: User
    SignUpUsecaseImpl->>SignupTokenRepository: deleteByToken(token)
    SignUpUsecaseImpl-->>Client: SignupUserResponse

Loading

Poem

In the warren of code, a new rule takes hold,
No bunny can signup with credentials of old!
Tokens are guarded, then whisked away,
No sneaky repeats, not even today.
Tests hop in circles, ensuring it’s true—
Signup is safer for me and for you!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between 65b8162 and 6613957.

📒 Files selected for processing (1)

• src/test/java/org/runimo/runimo/auth/service/SignUpUsecaseTest.java (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/test/java/org/runimo/runimo/auth/service/SignUpUsecaseTest.java

---

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.