[Fix/collecting daily stat]

[ekgns33]

작업내역

LocalDate 비교과정에서 != 연산자 사용으로 잘못된 계산이 이뤄지고 있었습니다. 이를 수정했습니다.

Summary by CodeRabbit

• Bug Fixes

  • Improved date comparison logic to ensure accurate grouping of daily statistics.

• Tests

  • Updated test cases to reflect new expected values for running statistics and added additional checks for daily distances.
  • Enhanced test data by adding a new running record entry for more comprehensive coverage.

[coderabbitai]

Warning

Rate limit exceeded

@ekgns33 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 7 minutes and 50 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between db458c6 and 5327327.

📒 Files selected for processing (1)

• src/test/java/org/runimo/runimo/records/api/RecordAcceptanceTest.java (2 hunks)

Walkthrough

The changes update the equality check for date comparison in the record service to use .equals() for LocalDate objects. Test assertions for monthly running statistics were modified to expect higher totals and an additional daily distance check. The SQL test data was expanded by adding a new running record entry.

Changes

File(s)	Change Summary
src/main/java/org/runimo/runimo/records/service/RecordFinder.java	Corrected date comparison in mapToDailyStatList to use .equals() for LocalDate objects.
src/test/java/org/runimo/runimo/records/api/RecordAcceptanceTest.java	Updated test assertions for monthly stats: increased totals and added a daily distance check for the sixth day.
src/test/resources/sql/weekly_record_data.sql	Added a new row to the running_record table for test data; adjusted previous entry for proper SQL syntax.

Poem

In fields of code where records run,
A date check fixed, the work is done.
New data sprints, the tests now cheer,
Totals rise—results are clear!
With every hop, our logic grows,
🐇 Onward through the data rows!

---

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Copilot]

Pull Request Overview

This pull request fixes an issue where the daily statistics were being calculated incorrectly due to an improper LocalDate comparison. The PR updates the expected values in the acceptance test and corrects the LocalDate comparison in the RecordFinder service.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File	Description
src/test/java/org/runimo/runimo/records/api/RecordAcceptanceTest.java	Updated expected statistic values and added a new check for daily stats.
src/main/java/org/runimo/runimo/records/service/RecordFinder.java	Changed LocalDate comparison from using "!=" to using ".equals" for proper equality checking.

Files not reviewed (1)

• src/test/resources/sql/weekly_record_data.sql: Language not supported