Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update your documentation to mention that http(s)-outbound does NOT work with libraries like request which doesn't use callback when making http.request #606

Open
exp-dev-dj opened this issue Aug 13, 2019 · 0 comments

Comments

@exp-dev-dj
Copy link

exp-dev-dj commented Aug 13, 2019

'http-outbound'/'https-outbound' events return undefined response statusCode if client uses request, request-promise or any other http libraries that do not use callback when making http.request. You mention this in the code comment (https://github.com/RuntimeTools/appmetrics/blob/master/probes/http-outbound-probe.js#L91), but there is no explanation on work-around for popular http libraries such as 'request', 'request-promise', 'node-fetch'... (node, 'axios' works)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant