Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pruebas y Optimizacion puntaje lighthouse #4

Open
sergiomeneses opened this issue Aug 25, 2023 · 5 comments
Open

Pruebas y Optimizacion puntaje lighthouse #4

sergiomeneses opened this issue Aug 25, 2023 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@sergiomeneses
Copy link
Member

No description provided.

@sergiomeneses sergiomeneses added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Aug 25, 2023
@sergiomeneses sergiomeneses added this to the Version 1.0 milestone Aug 25, 2023
@Lemin-n
Copy link
Collaborator

Lemin-n commented Aug 27, 2023

Despues de algunas pruebas con el Cargo.toml el bundle paso de 378kb a 250kb.

[profile.custom-profile]
opt-level = "z"   # Optimize for size.
lto = true        # Link time optimization.
incremental = true
codegen-units = 1 # Allow for maximum size reduction optimizations.
debug-assertions = false

Con este custom profile se logra optimizar el bundle size, se deberia asingar al release profile dado que trunk no soporta custom profiles.

Con respecto al puntaje de Lighthouse:
debug profile:

  • Performance: 60
  • Accessibility: 65
  • Best Practices: 100
  • SEO: 64

release profile:

  • Performance: 79
  • Accessibility: 65
  • Best Practices: 100
  • SEO: 64

custom profile

  • Performance: 80
  • Accessibility: 65
  • Best Practices: 100
  • SEO: 64

El mayor bottleneck serian las imágenes dado que una sola imagen ocupa 3mb.

@Phosphorus-M
Copy link
Member

El mayor bottleneck serian las imágenes dado que una sola imagen ocupa 3mb.

Y QUE PASA SI QUIERO ESA IMAGEN EN 4K?!

Bromeo, si, hay que cambiar eso

@sergiomeneses
Copy link
Member Author

sergiomeneses commented Aug 28, 2023

El mayor bottleneck serian las imágenes dado que una sola imagen ocupa 3mb

Podemos generar imágenes según el dispositivo visitante para optimizar esto, además de reducir el tamaño de las imagenes

@Lemin-n
Copy link
Collaborator

Lemin-n commented Sep 2, 2023

Actualmente tenemos las siguientes medias en Lighthouse:

release profile:
Performance: 90~100
Accessibility: 71
Best Practices: 100
SEO: 92

Aun falta agregar alt a las imágenes, optimizar el contraste y modificar algunas tags por accessibility.

@Phosphorus-M
Copy link
Member

Viene bien! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: In Progress
Development

No branches or pull requests

3 participants