Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store HGVS resolution method on imported allele info #1099

Closed
davmlaw opened this issue Jun 28, 2024 · 2 comments
Closed

Store HGVS resolution method on imported allele info #1099

davmlaw opened this issue Jun 28, 2024 · 2 comments

Comments

@davmlaw
Copy link
Contributor

davmlaw commented Jun 28, 2024

Raised from

https://github.com/SACGF/variantgrid_private/issues/3653

In this issue:

https://github.com/SACGF/variantgrid_private/issues/3654

We store the hgvs matcher and the method (whether internal or clingen fallback) on resolved variant info

We should do the same on Imported Allele info when it comes in (will this always be the same as resolved variant info for non lifted over build?)

@davmlaw
Copy link
Contributor Author

davmlaw commented Jul 4, 2024

This was partially stored in the Allele info "note". That stores what was tried and a more human readable message

What we're storing here is a well identified version of what was used to resolve/fallback etc.

I added this as an admin only field to view at the top of import info page. Also added (admin only) the import creation date/modified as I sometimes find that useful

@EmmaTudini
Copy link
Contributor

EmmaTudini commented Jul 13, 2024

Test

  • As non-admin went to allele 32361

  • Selected imported as link
    Expected output: Extra additions should not appear
    Actual output: Passed

  • As admin went to allele 32361

  • Selected imported as link
    Expected output: SHould show extra information
    Actual output: Passed

Screenshot 2024-07-13 at 12.15.43 pm.png

Noted: Also confirmed that this shows on imported alleles page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants