Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gene symbol HGVS search - report errors #1110

Open
davmlaw opened this issue Jul 10, 2024 · 1 comment
Open

Gene symbol HGVS search - report errors #1110

davmlaw opened this issue Jul 10, 2024 · 1 comment

Comments

@davmlaw
Copy link
Contributor

davmlaw commented Jul 10, 2024

Raised from SACGF/variantgrid_private#3634

If you search for BMD:c.10889G>A

It returns some results. However, we also swallow the errors, eg:

Error resolving transcripts: ENST00000378043.9 (MANE Select), NM_004183.4 (MANE Select): c.10889 coordinate is out of bounds

These are only reported if there are no results.

We would like to return the errors as well as the results - I am not sure how to do that as we yield SearchResult but if you throw an exception it just exits the function and never returns to get more results

Can we yield something that ends up looking like an exception?

@davmlaw davmlaw added bug Something isn't working search HGVS and removed bug Something isn't working labels Jul 10, 2024
@davmlaw
Copy link
Contributor Author

davmlaw commented Aug 14, 2024

Changes in #1105 now allow us to return SearchResult failures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant