Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnomADv4 common filter #1119

Open
davmlaw opened this issue Jul 15, 2024 · 2 comments
Open

gnomADv4 common filter #1119

davmlaw opened this issue Jul 15, 2024 · 2 comments
Assignees

Comments

@davmlaw
Copy link
Contributor

davmlaw commented Jul 15, 2024

We are still using 3.1 for GRCh38, haven't generated one for new gnomAD 4

Code currently dies looking for this version, which means installing from scratch no longer works

Need to create a v4 GRCh38 gnomad AF file and alter pipelines

See:

settings.VCF_IMPORT_COMMON_FILTERS

Make sure you put the gnomAD version in the name (unlike last one)

@davmlaw davmlaw changed the title gnomAD common filter gnomADv4 common filter Jul 15, 2024
@davmlaw davmlaw self-assigned this Jul 29, 2024
@davmlaw
Copy link
Contributor Author

davmlaw commented Jul 31, 2024

Not user testable

Added to deployment check - when upgrading systems should get a notice to download it if not there (and Copied to variantgrid.com - so available for download)

@davmlaw
Copy link
Contributor Author

davmlaw commented Aug 9, 2024

Thinking about it, we should only do this optimisation when the common filter gnomAD version equals the analysis gnomAD version - we should do an explicit check

This is stored in an object CohortGenotype.CohortGenotypeCommonFilterVersion

Maybe even expose that somewhere eg in node debug tab

The place to where it's set is:

analysis.models.nodes.analysis_node.AnalysisNode.get_annotation_kwargs

The place that it's tested and decide what CGC to include is:

snpdb.models.models_cohort.CohortGenotypeCollection.get_annotation_kwargs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant