Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace QC graphs with plotly graphs #1120

Closed
davmlaw opened this issue Jul 17, 2024 · 4 comments
Closed

Replace QC graphs with plotly graphs #1120

davmlaw opened this issue Jul 17, 2024 · 4 comments
Assignees
Labels

Comments

@davmlaw
Copy link
Contributor

davmlaw commented Jul 17, 2024

It's way better to do graphs in JS than put them on a queue and serve an image, we should try and remove all the old style plots if we can

Brought up in priority due to https://github.com/SACGF/variantgrid_sapath/issues/315 and the fact I want a fun task after a hard week (and it's only Wednesday)

Patch back to SAP

@davmlaw davmlaw added the Graph label Jul 17, 2024
@davmlaw davmlaw self-assigned this Jul 17, 2024
davmlaw added a commit that referenced this issue Jul 17, 2024
davmlaw added a commit that referenced this issue Jul 17, 2024
@davmlaw
Copy link
Contributor Author

davmlaw commented Jul 17, 2024

The individual data point for a sequencing run basically falls apart once you have more than 10, 20 etc - so we might as well just fall back on plotting per enrichment kit.

I think all we really need is type/column (from existing form)

davmlaw added a commit that referenced this issue Jul 17, 2024
@davmlaw
Copy link
Contributor Author

davmlaw commented Jul 17, 2024

If patching back to SAP need to cherry pick:

2f58874
63bf1ae
6dcae5f

davmlaw added a commit that referenced this issue Jul 17, 2024
davmlaw added a commit that referenced this issue Jul 17, 2024
davmlaw added a commit that referenced this issue Jul 17, 2024
# Conflicts:
#	seqauto/forms.py
#	seqauto/graphs/qc_column_boxplot_graph.py
#	seqauto/graphs/qc_column_line_graph.py
@davmlaw
Copy link
Contributor Author

davmlaw commented Jul 17, 2024

Deployed here:

http://frgeneseq02.imvs.sa.gov.au:90/

Work out what else should go into that HF - then do thorough testing etc

There are some changes on prod to do with celery concurrency that need to be put into code

davmlaw added a commit that referenced this issue Jul 19, 2024
davmlaw added a commit that referenced this issue Jul 19, 2024
davmlaw added a commit that referenced this issue Jul 19, 2024
davmlaw added a commit that referenced this issue Jul 19, 2024
@davmlaw
Copy link
Contributor Author

davmlaw commented Aug 4, 2024

tested and deployed

@davmlaw davmlaw closed this as completed Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant