Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move creating new annotation version into management command #1121

Open
davmlaw opened this issue Jul 17, 2024 · 1 comment
Open

Move creating new annotation version into management command #1121

davmlaw opened this issue Jul 17, 2024 · 1 comment
Assignees

Comments

@davmlaw
Copy link
Contributor

davmlaw commented Jul 17, 2024

Currently, we do a get_or_create in here annotation.annotation_versions.get_variant_annotation_version which is triggered by visiting annotation pages

Better to do in management command and/or deployment tool

@davmlaw davmlaw self-assigned this Jul 17, 2024
@davmlaw davmlaw added this to the VG4 non-critical milestone Jul 17, 2024
@davmlaw
Copy link
Contributor Author

davmlaw commented Jul 31, 2024

Made it check vs VEP current - but this blew annotation page out to ~20 seconds

I split up the annotation page per genome build so now it can at least do things in parallel

User testing

The main point of this is to not accidentally trigger an unexpected annotation version upgrade if the underlying VEP and latest DB variant annotaiton version get out of sync - which requires a bit of deployment config to see

But should test that annotation page works as before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant