Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make artifact creation dependent on build status #41

Open
brucellino opened this issue Jun 23, 2014 · 3 comments
Open

make artifact creation dependent on build status #41

brucellino opened this issue Jun 23, 2014 · 3 comments

Comments

@brucellino
Copy link
Member

the artifacts (build.tar.gz) are currently being made irrespective of whether the build is finished properly.

This should not be... it the artifact should be created by the job in jenkins, not the script, as is currently happening.

@brucellino brucellino added this to the Version-0.1.0 milestone Jun 23, 2014
@fanie-riekert
Copy link

Be careful tarballing in the jenkins job will not work with matrix jobs.
I am referring to the normal jenkins artifact creation config in a job,
this step is only run on the master job for matrix jobs, and not for
each axis, which is why I did the tarballing inside the script. That
should probably then be made conditional on the previous commands exit
status's.

On 23/06/2014 18:06, Bruce Becker wrote:

the artifacts (build.tar.gz) are currently being made irrespective of
whether the build is finished properly.

This should not be... it the artifact should be created by the job in
jenkins, not the script, as is currently happening.


Reply to this email directly or view it on GitHub
#41.

@brucellino
Copy link
Member Author

Ah ok, thanks !

We have to build it in the script then, I guess and make sure there's
adequate documentation for new devs.

On 23 June 2014 18:18, fanie-riekert [email protected] wrote:

Be careful tarballing in the jenkins job will not work with matrix jobs.
I am referring to the normal jenkins artifact creation config in a job,
this step is only run on the master job for matrix jobs, and not for
each axis, which is why I did the tarballing inside the script. That
should probably then be made conditional on the previous commands exit
status's.

On 23/06/2014 18:06, Bruce Becker wrote:

the artifacts (build.tar.gz) are currently being made irrespective of
whether the build is finished properly.

This should not be... it the artifact should be created by the job in
jenkins, not the script, as is currently happening.


Reply to this email directly or view it on GitHub
#41.


Reply to this email directly or view it on GitHub
#41 (comment)
.

Dr. Bruce Becker,
Coordinator, South African National Grid
Meraka Institute, CSIR
Meiring Naude Road
Pretoria 0001 South Africa
+27 12 841 3746 (w) | +27 12 841-4829 (f) |
+27 84 989 6169 (m) | + 39 392 622 9279
AIM/GTalk/Skype/MSN/Jabber : brucellino
http://www.sagrid.ac.za

@fanie-riekert
Copy link

There are work arounds in jenkins it self, which require two jobs, one
the matrix and the second a normal job that joins the, results from the
matrix job. I found this configuration far more work and too fragile.

Perhaps, it would be a good idea to use the job number from jenkins in
the artifacts name. ie build-#{xxx}.tar.gz and have a symlink
latest-successful to that build or something similar?

On 23/06/2014 18:25, Bruce Becker wrote:

Ah ok, thanks !

We have to build it in the script then, I guess and make sure there's
adequate documentation for new devs.

On 23 June 2014 18:18, fanie-riekert [email protected] wrote:

Be careful tarballing in the jenkins job will not work with matrix
jobs.
I am referring to the normal jenkins artifact creation config in a job,
this step is only run on the master job for matrix jobs, and not for
each axis, which is why I did the tarballing inside the script. That
should probably then be made conditional on the previous commands exit
status's.

On 23/06/2014 18:06, Bruce Becker wrote:

the artifacts (build.tar.gz) are currently being made irrespective of
whether the build is finished properly.

This should not be... it the artifact should be created by the job in
jenkins, not the script, as is currently happening.


Reply to this email directly or view it on GitHub
#41.


Reply to this email directly or view it on GitHub

#41 (comment)
.

Dr. Bruce Becker,
Coordinator, South African National Grid
Meraka Institute, CSIR
Meiring Naude Road
Pretoria 0001 South Africa
+27 12 841 3746 (w) | +27 12 841-4829 (f) |
+27 84 989 6169 (m) | + 39 392 622 9279
AIM/GTalk/Skype/MSN/Jabber : brucellino
http://www.sagrid.ac.za


Reply to this email directly or view it on GitHub
#41 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants