feat(buildsettings): add dockerBuild support in CreateBuildSettingsInfo#5780
Open
feat(buildsettings): add dockerBuild support in CreateBuildSettingsInfo#5780
Conversation
dockerBuild was falling through to the default branch, emitting a warning and returning empty buildSettingsInfo. Add it as a first-class supported tool alongside kanikoExecute and cnbBuild.
ashlymat
reviewed
May 6, 2026
kanikoExecute is Jenkins/Kubernetes-centric and requires a sidecar container. Users running on GitHub Actions have a simpler native alternative (dockerBuild via Docker BuildKit). Add a visible note at the top of the doc so they discover it before going deep into Kaniko setup.
Contributor
Author
|
/it-go |
And-tab-8889
reviewed
May 7, 2026
And-tab-8889
left a comment
And-tab-8889
left a comment
There was a problem hiding this comment.
Overall the change is correct and minimal. Four things worth addressing before merge — see inline comments below, plus one general note:
cnbBuild.md cross-reference missing. kanikoExecute.md gets a note pointing GHA users toward dockerBuild, but cnbBuild.md does not. Since all three are container image build alternatives in GHA pipelines, the same note belongs there too.
…' into fskhiri/dockerBuild
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
dockerBuild was falling through to the default branch, emitting a warning and returning empty buildSettingsInfo. Add it as a first-class supported tool alongside kanikoExecute and cnbBuild
Checklist