chore:fix sonar issues (#3685)

* fix sonar issues

* fix snapshots

* fix js occurrences

* undo change for telemetry

* add cset

* fix

---------

Co-authored-by: Austin Devine <[email protected]>

Author: heimwege

.changeset/cool-crabs-type.md

@@ -0,0 +1,79 @@
+---
+'@sap-ux/ui5-library-reference-sub-generator': patch
+'@sap-ux/abap-deploy-config-sub-generator': patch
+'@sap-ux/cds-odata-annotation-converter': patch
+'@sap-ux/cf-deploy-config-sub-generator': patch
+'@sap-ux/ui5-library-reference-inquirer': patch
+'@sap-ux/xml-odata-annotation-converter': patch
+'@sap-ux/repo-app-import-sub-generator': patch
+'@sap-ux/adp-flp-config-sub-generator': patch
+'@sap-ux/ui5-library-reference-writer': patch
+'@sap-ux/deploy-config-sub-generator': patch
+'@sap-ux-private/adaptation-editor-tests': patch
+'@sap-ux/abap-deploy-config-writer': patch
+'@sap-ux/cf-deploy-config-inquirer': patch
+'@sap-ux/eslint-plugin-fiori-tools': patch
+'@sap-ux-private/preview-middleware-client': patch
+'@sap-ux/ui5-library-sub-generator': patch
+'@sap-ux/backend-proxy-middleware': patch
+'@sap-ux/flp-config-sub-generator': patch
+'@sap-ux/mockserver-config-writer': patch
+'@sap-ux/ui-service-sub-generator': patch
+'@sap-ux/ui5-application-inquirer': patch
+'@sap-ux/cf-deploy-config-writer': patch
+'@sap-ux/fiori-app-sub-generator': patch
+'@sap-ux/project-input-validator': patch
+'@sap-ux/serve-static-middleware': patch
+'@sap-ux/fiori-freestyle-writer': patch
+'@sap-ux/fiori-generator-shared': patch
+'@sap-ux/odata-service-inquirer': patch
+'@sap-ux/ui5-application-writer': patch
+'@sap-ux-private/ui-prompting-examples': patch
+'@sap-ux/cds-annotation-parser': patch
+'@sap-ux/fiori-docs-embeddings': patch
+'@sap-ux/fiori-elements-writer': patch
+'@sap-ux/jest-runner-puppeteer': patch
+'@sap-ux/odata-annotation-core': patch
+'@sap-ux/annotation-generator': patch
+'@sap-ux/fiori-annotation-api': patch
+'@sap-ux/fiori-tools-settings': patch
+'@sap-ux/odata-service-writer': patch
+'@sap-ux/ui5-library-inquirer': patch
+'@sap-ux/ui5-proxy-middleware': patch
+'@sap-ux/jest-file-matchers': patch
+'@sap-ux/odata-vocabularies': patch
+'@sap-ux/preview-middleware': patch
+'@sap-ux/ui5-library-writer': patch
+'@sap-ux/app-config-writer': patch
+'@sap-ux/cap-config-writer': patch
+'@sap-ux/environment-check': patch
+'@sap-ux/project-integrity': patch
+'@sap-ux/reload-middleware': patch
+'@sap-ux/generator-simple-fe': patch
+'@sap-ux/fiori-mcp-server': patch
+'@sap-ux/axios-extension': patch
+'@sap-ux/inquirer-common': patch
+'@sap-ux/ui5-test-writer': patch
+'@sap-ux/deploy-tooling': patch
+'@sap-ux/project-access': patch
+'@sap-ux/fe-fpm-writer': patch
+'@sap-ux/generator-adp': patch
+'@sap-ux/launch-config': patch
+'@sap-ux/system-access': patch
+'@sap-ux/nodejs-utils': patch
+'@sap-ux/ui-prompting': patch
+'@sap-ux/adp-tooling': patch
+'@sap-ux/fe-fpm-cli': patch
+'@sap-ux-private/playwright': patch
+'@sap-ux/ui5-config': patch
+'@sap-ux/odata-cli': patch
+'@sap-ux/btp-utils': patch
+'@sap-ux/telemetry': patch
+'@sap-ux/ui5-info': patch
+'@sap-ux/create': patch
+'@sap-ux/store': patch
+'@sap-ux/i18n': patch
+'@sap-ux/yaml': patch
+---
+
+chore: fix Sonar issues

examples/fe-fpm-cli/src/index.ts

@@ -9,7 +9,7 @@ import inquirer from 'inquirer';
 import { create as createStorage } from 'mem-fs';
 import type { Editor } from 'mem-fs-editor';
 import { create } from 'mem-fs-editor';
-import { join } from 'path';
+import { join } from 'node:path';
 import { promisify } from 'util';
 
 const sampleAppPath = join(__dirname, '../sample/fe-app');

examples/odata-cli/src/activities.ts

@@ -1,5 +1,5 @@
-import { writeFileSync } from 'fs';
-import { join } from 'path';
+import { writeFileSync } from 'node:fs';
+import { join } from 'node:path';
 import type { AbapServiceProvider, ArchiveFileNode } from '@sap-ux/axios-extension';
 import {
     ODataVersion,

examples/odata-cli/src/index.ts

@@ -1,6 +1,6 @@
 import { isAppStudio } from '@sap-ux/btp-utils';
-import { existsSync, mkdirSync } from 'fs';
-import { join } from 'path';
+import { existsSync, mkdirSync } from 'node:fs';
+import { join } from 'node:path';
 import type { TestActivity, TestTarget } from './types';
 import { logger } from './types';
 import { testWithAbapSystem, testWithDestination, testWithAbapBtpSystem, testWithCloudAbapSystem } from './targets';

examples/odata-cli/src/targets.ts

@@ -6,7 +6,7 @@ import {
     createForDestination
 } from '@sap-ux/axios-extension';
 import { isAbapSystem, listDestinations } from '@sap-ux/btp-utils';
-import { readFileSync } from 'fs';
+import { readFileSync } from 'node:fs';
 import type { TestActivity } from './types';
 import { logger } from './types';
 

examples/simple-generator/src/app/index.ts

@@ -1,4 +1,4 @@
-import { join } from 'path';
+import { join } from 'node:path';
 import Generator from 'yeoman-generator';
 
 import type { Template, LROPSettings, OVPSettings, FPMSettings } from '@sap-ux/fiori-elements-writer';

examples/ui-prompting-examples/.storybook/main.ts

@@ -1,4 +1,4 @@
-import { resolve } from 'path';
+import { resolve } from 'node:path';
 import { createWebSocketConnection } from '../src/backend';
 
 module.exports = {

examples/ui-prompting-examples/src/addons/project/actions.ts

@@ -1,5 +1,5 @@
-import { join } from 'path';
-import { existsSync } from 'fs';
+import { join } from 'node:path';
+import { existsSync } from 'node:fs';
 import { GET_PROJECT_PATH, UPDATE_PROJECT_PATH, UPDATE_PROJECT_PATH_RESULT, SET_PROJECT_PATH } from './types';
 import type { ProjectActions } from './types';
 import { getApplication, setApplication, testAppPath } from './project';

examples/ui-prompting-examples/src/addons/project/project.ts

@@ -1,4 +1,4 @@
-import { join } from 'path';
+import { join } from 'node:path';
 import type { ApplicationInformation } from './types';
 
 export const testAppPath = join(__dirname, `../../../test-output/fe-app-${Date.now()}`);

examples/ui-prompting-examples/src/backend/api.ts

@@ -1,5 +1,5 @@
 import { PromptsAPI } from '@sap-ux/fe-fpm-writer';
-import { join } from 'path';
+import { join } from 'node:path';
 import type { Editor } from 'mem-fs-editor';
 import { PromptsType } from '../utils';
 import type { ApplicationInformation } from '../addons/project';