Skip to content

Commit a22b24e

Browse files
heimwegegithub-actions[bot]ytpo-lyne
authored
feat(preview-middleware): enhance logging for remote connection of windows users (#3676)
* enhance logging for windows users * enhance logging for windows users * Linting auto fix commit --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Annemarie Frank <[email protected]>
1 parent 320b31b commit a22b24e

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

.changeset/fresh-singers-think.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@sap-ux/preview-middleware': patch
3+
---
4+
5+
enhance logging for remote connection of windows users

packages/preview-middleware/src/base/remote-url.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,11 @@ export async function logRemoteUrl(logger: ToolsLogger): Promise<void> {
2424

2525
if (remoteUrl) {
2626
logger.info(`Remote URL: ${remoteUrl}`);
27+
if (process.platform === 'win32') {
28+
logger.warn(
29+
`Windows users: Ensure Windows Firewall allows inbound connections on the port.\n1. Open Windows Firewall with Advanced Security (wf.msc)\n2. Create new Inbound Rule for the port (default: 8080)\n3. Allow TCP connections on the specified port`
30+
);
31+
}
2732
logger.info('Scan the QR code below with your mobile device to access the preview:');
2833
await generateQRCode(remoteUrl);
2934
}

0 commit comments

Comments
 (0)