Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui5-table: component breaks if imported from both the main and compat package #9920

Closed
1 task done
Lukas742 opened this issue Sep 23, 2024 · 2 comments · Fixed by #9929
Closed
1 task done

ui5-table: component breaks if imported from both the main and compat package #9920

Lukas742 opened this issue Sep 23, 2024 · 2 comments · Fixed by #9929
Assignees
Labels
bug This issue is a bug in the code documentation This issue is about wrong documentation TOPIC Core

Comments

@Lukas742
Copy link
Collaborator

Bug Description

If both the Table from the compat package and the main package are used in the same app, the component breaks because the custom element tag name is the same for both tables.

I'm not sure if this can be supported without a breaking change, but if not, it should probably be mentioned in the documentation.

Related UI5WCR issue: SAP/ui5-webcomponents-react#6344

Affected Component

ui5-table

Expected Behaviour

No response

Isolated Example

https://stackblitz.com/edit/github-9tzm9t?file=main.js,index.html

Steps to Reproduce

  1. Open the StackBlitz example
  2. Observe that both tables are broken.
  3. Comment out the imports for one of the tables.
  4. See that the other table is now displaying as intended.

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

2.2.0

Browser

Chrome, Edge, Firefox, Safari

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@Lukas742 Lukas742 added the bug This issue is a bug in the code label Sep 23, 2024
@ilhan007 ilhan007 added documentation This issue is about wrong documentation TOPIC Core labels Sep 24, 2024
@ilhan007
Copy link
Member

Hi @Lukas742 both tables use the ui5-table tag and one should choose the one or the other. We will state it more prominently.

@pskelin
Copy link
Contributor

pskelin commented Sep 25, 2024

The assumption for that was, that you won't use both tables from the same app, you will either use the compat table or upgrade to the new table.

For the micro front end scenarios, they will be in a different bundle and will have to use scoping anyway, so there won't be a clash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code documentation This issue is about wrong documentation TOPIC Core
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants