Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modularization of SAR processing engine #205

Open
johntruckenbrodt opened this issue May 25, 2024 · 0 comments
Open

modularization of SAR processing engine #205

johntruckenbrodt opened this issue May 25, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@johntruckenbrodt
Copy link
Member

johntruckenbrodt commented May 25, 2024

Currently SNAP is tightly integrated into the processor. This makes it hard to add alternatives. A better modularization could look like this:

  • add a dedicated section SNAP to the config.ini file gathering
    • relevant configuration from config.snap_conf (move the rest somewhere else)
    • the configuration parameter snap_gpt_args
  • remove the option to define multiple processing sections in the config.ini. This makes the file too complicated. One section PROCESSING, one METADATA and one per processing engine is enough (solved in start processing with 's1rb process'; new option 's1rb init' to initialize config file #215)
  • add a configuration parameter, e.g. engine, to let users define the engine. Its name should match a file <name>.py and a section in config.ini should have the same name in uppercase

The config.ini file could look like this:

engine = 'snap'

[SNAP]
gpt_args = 
...

The script processor.py could look like this:

import importlib
engine = config['engine']
processor = importlib.import_module(engine)
...
processor.process(..., **config[engine])
@johntruckenbrodt johntruckenbrodt added the enhancement New feature or request label May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant