From 79a38fbf9f3bce59f167e02281d6d545e15337a6 Mon Sep 17 00:00:00 2001 From: Sander Roet Date: Thu, 22 Feb 2024 15:04:51 +0100 Subject: [PATCH] Update coverage.yml add linking of missing lines and restrict permissions again to something the "seems" reasonable --- .github/workflows/coverage.yml | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index 21bee063..a36d2f1e 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -14,16 +14,19 @@ jobs: runs-on: [self-hosted, linux, x64, gpu] container: image: ubuntu - # DEBUG to make sure the action can pass at all - permissions: write-all - # Allow publishing new comments on PRs - # pull-requests: write - # Allow for editing existing comments - # contents: write + permissions: # Read the action that triggered this one - # actions: read + actions: read # Allow to write check runs - # checks: read + checks: write + # Allow for editing existing comments + contents: write + # Allow publishing new comments on PRs + pull-requests: write + # Read and update commit statuses + statuses: write + + # Allow to check commit statusses steps: - name: Download Artifact @@ -44,5 +47,6 @@ jobs: minimum_coverage: 75 show_missing: True fail_below_threshold: True + link_missing_lines: True # False for now, might set to true later only_changed_files: False