-
-
Notifications
You must be signed in to change notification settings - Fork 340
Bibtex stripping extra extensions #4789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kprussing
wants to merge
9
commits into
SCons:master
Choose a base branch
from
kprussing:bibtex-striping-extra-extensions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+90
−4
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
77b92c4
Add preliminary test showing failure
kprussing 283ca61
Pass the correct files to the Actions
kprussing fc0acf9
Compare the normalized text
kprussing 5918bc1
Do not pull in the environment
kprussing aef7979
Merge branch 'master' into bibtex-striping-extra-extensions
kprussing 2869dad
Update changes and release notes
kprussing 5448845
Use the correct biber extension
kprussing 020f829
[ci skip] switch test to use current test template file header
bdbaddog db4f3ac
Merge remote-tracking branch 'upstream/master' into bibtex-striping-e…
kprussing File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| #!/usr/bin/env python | ||
| # | ||
| # MIT License | ||
| # | ||
| # Copyright The SCons Foundation | ||
| # | ||
| # Permission is hereby granted, free of charge, to any person obtaining | ||
| # a copy of this software and associated documentation files (the | ||
| # "Software"), to deal in the Software without restriction, including | ||
| # without limitation the rights to use, copy, modify, merge, publish, | ||
| # distribute, sublicense, and/or sell copies of the Software, and to | ||
| # permit persons to whom the Software is furnished to do so, subject to | ||
| # the following conditions: | ||
| # | ||
| # The above copyright notice and this permission notice shall be included | ||
| # in all copies or substantial portions of the Software. | ||
| # | ||
| # THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY | ||
| # KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE | ||
| # WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND | ||
| # NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE | ||
| # LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION | ||
| # OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION | ||
| # WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
|
|
||
| """ | ||
| Verify that running LaTeX with a file named main.extra.tex pulls the | ||
| right bibliography file. | ||
| """ | ||
|
|
||
| import TestSCons | ||
|
|
||
| test = TestSCons.TestSCons() | ||
|
|
||
| pdflatex = test.where_is('pdflatex') | ||
|
|
||
| if not pdflatex: | ||
| test.skip_test("Could not find 'pdflatex'; skipping test(s).\n") | ||
|
|
||
| mains = ["main.tex", "main.extra.tex"] | ||
|
|
||
| test.write(["SConstruct"], f"""\ | ||
| import os | ||
| env = Environment(tools=['pdftex', 'tex']) | ||
| env.PDF({mains}) | ||
| """) | ||
|
|
||
| body_content = r"""\documentclass{article} | ||
| \begin{document} | ||
| SCons \cite{scons}! | ||
| \bibliography{references} | ||
| \bibliographystyle{plain} | ||
| \end{document} | ||
| """ | ||
|
|
||
| for _ in mains: | ||
| test.write(_, body_content) | ||
|
|
||
| test.write("references.bib", r""" | ||
| @misc{scons, | ||
| title = {SCons}, | ||
| url = {https://scons.org}, | ||
| language = {en-US}, | ||
| urldate = {2025-08-15}, | ||
| author = {{SCons} {Foundation}}, | ||
| year = {2025}, | ||
| } | ||
| """) | ||
|
|
||
| test.run() | ||
|
|
||
| pdfs = [test.normalize_pdf(test.read(_[:-3] + "pdf")) for _ in mains] | ||
| test.fail_test(pdfs[0] != pdfs[1]) | ||
| test.pass_test() | ||
|
|
||
| # Local Variables: | ||
| # tab-width:4 | ||
| # indent-tabs-mode:nil | ||
| # End: | ||
| # vim: set expandtab tabstop=4 shiftwidth=4: | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
though it has nothing to do with correctness, we often sneak in a line before the initial env creation like
This is purely a hack for performance running the testsuite, and isn't something people should actually have to do. No downvote if not changed.