Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login (Service Provider) #34

Open
MarwanOSayed opened this issue May 1, 2017 · 0 comments
Open

Login (Service Provider) #34

MarwanOSayed opened this issue May 1, 2017 · 0 comments

Comments

@MarwanOSayed
Copy link

MarwanOSayed commented May 1, 2017

Severity (high)
////////////////////////////////////////////////////////
Reported by: Marwan Osama
////////////////////////////////////////////////////////
Description:
Logging in as a service provider is completely dysfunctional — does any generate any form of response and crashes the server regardless of whether username and password are correct or not. However, if username and password fields are left empty, it redirects to /#/homepage then crashes the server, too.
Issue exists in these files/lines:

app/controllers/servicecontroller.js:29

////////////////////////////////////////////////////////
Steps to reproduce the issue:

  1. Go to homepage (/#/home)
  2. Click on "service provider"
  3. Click on "click To login"
  4. Write any random or correct data in any or both of the fields
  5. Click on "login"
  6. A meaningless message appears and server crashes (see error log in the bottom of the page)

////////////////////////////////////////////////////////
Expected result:
Redirect to /#/homepage with user saved in session if username and password are correct. An appropriate message should be displayed in case of login success or failure.

//////////////////////////////////////////////////////
Error log:

/404gotfound-master/app/controllers/servicecontroller.js:29
if(req.body.password==servicelogin.password){
^
TypeError: Cannot read property 'password' of null
at Query. (/home/marwan/Downloads/404gotfound-master/app/controllers/servicecontroller.js:29:35)
at /home/marwan/Downloads/404gotfound-master/node_modules/kareem/index.js:177:19
at /home/marwan/Downloads/404gotfound-master/node_modules/kareem/index.js:109:16
at _combinedTickCallback (internal/process/next_tick.js:67:7)
at process._tickCallback (internal/process/next_tick.js:98:9)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant