Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version restriction for CSFML #255

Closed
eXpl0it3r opened this issue Jun 3, 2024 · 1 comment · Fixed by #258
Closed

Add version restriction for CSFML #255

eXpl0it3r opened this issue Jun 3, 2024 · 1 comment · Fixed by #258
Labels
Feature New functionality or extending of an existing one
Milestone

Comments

@eXpl0it3r
Copy link
Member

eXpl0it3r commented Jun 3, 2024

Nuspec allows for limiting version usages, so issues like #245 can't happen again.

The goal would be to lock SFML.Net X.Y.Z with CSFML X.Y so people were prevented from say installing CSFML 2.6 while using SFML.Net 2.5.1 causing potential breakage.

https://learn.microsoft.com/en-us/nuget/concepts/package-versioning?tabs=semver20sort

@eXpl0it3r eXpl0it3r added the Feature New functionality or extending of an existing one label Jun 3, 2024
@eXpl0it3r eXpl0it3r mentioned this issue Jun 3, 2024
22 tasks
@Marioalexsan
Copy link
Member

Marioalexsan commented Jun 5, 2024

I'm not sure if this is possible given that applications can override the versions of packages used by dependencies:
https://learn.microsoft.com/en-us/nuget/concepts/dependency-resolution#direct-dependency-wins
image

@eXpl0it3r eXpl0it3r linked a pull request Jun 6, 2024 that will close this issue
@eXpl0it3r eXpl0it3r added this to the 2.6.0 milestone Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New functionality or extending of an existing one
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants