Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image compression broken since refactor #216

Open
Raupinger opened this issue Jun 27, 2024 · 2 comments
Open

image compression broken since refactor #216

Raupinger opened this issue Jun 27, 2024 · 2 comments

Comments

@Raupinger
Copy link
Contributor

Raupinger commented Jun 27, 2024

I recently updated my main abrechnung instance and have been unable to upload images since. Seems reproducible on https://demo.abrechnung.sft.lol as well.

How to reproduce:

  • create event and add an image bigger than 1mb
  • try to save

expected behaviour:
image gets compressed to just under 1mb
actual behaviour:
image is slightly to big and server returns 413 Request Entity Too Large

It seems like the code for the upload dialog has been refactored since I contributed the initial implementation of the compression feature. Just looking at the changes on GitHub, I don't immediately see how the actual compression part would have changed though.

@Raupinger
Copy link
Contributor Author

Raupinger commented Jun 27, 2024

I plan on looking into this myself eventually, but since i cant downgrade to an old fronted with my up-to-date server anymore i need set up a dev server first before i can bisect this and i dont know when I'll find time for that. Just wanted to open an issue first in case someone else runs into this.

@mikonse
Copy link
Contributor

mikonse commented Jun 28, 2024

Hi,
thanks for the report!
Always happy to accept PRs if you get around to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants