Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added custom resolution size for main and game #1672

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Added custom resolution size for main and game #1672

wants to merge 9 commits into from

Conversation

RaulGalvez288
Copy link

Partial fix: #1546

Implemented width and height parameters for main and game start modes.

Still have to add vsync and window modes.

@RaulGalvez288 RaulGalvez288 marked this pull request as draft August 21, 2024 00:54
heinezen
heinezen requested changes Aug 21, 2024
View reviewed changes
Copy link
Member

@heinezen heinezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thank you so much! I can already give you some feedback on the work you've done.

libopenage/engine/engine.cpp Outdated Show resolved Hide resolved
libopenage/engine/engine.cpp Outdated Show resolved Hide resolved
openage/game/main_cpp.pyx Outdated Show resolved Hide resolved
openage/main/main_cpp.pyx Outdated Show resolved Hide resolved
@RaulGalvez288
Copy link
Author

I did want to ask if changing the engine.cpp and engine.h was alright for this issue? or if I should just use Window::render like #1553

@heinezen
Copy link
Member

@RaulGalvez288 There is

openage/libopenage/renderer/window.h

Lines 27 to 38 in d09adb0

struct window_settings {
// Width of the window in pixels.
size_t width = 1024;
// Height of the window in pixels.
size_t height = 768;
// Graphics API to use in the window's renderer.
graphics_api_t backend = graphics_api_t::DEFAULT;
// If true, enable vsync.
bool vsync = true;
// If true, enable debug logging for the selected backend.
bool debug = false;
};
if you want to use that.

@heinezen
Copy link
Member

@RaulGalvez288 Are you planning to continue working on this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heinezen heinezen heinezen requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI parameters for window settings
2 participants
@RaulGalvez288 @heinezen