Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally check if all uniform values have been set #1681

Open
2 tasks
heinezen opened this issue Aug 25, 2024 · 4 comments
Open
2 tasks

Optionally check if all uniform values have been set #1681

heinezen opened this issue Aug 25, 2024 · 4 comments
Labels
area: renderer Concerns our graphics renderer good first issue Suitable for newcomers hacktoberfest For newcomers from Hacktoberfest event improvement Enhancement of an existing component just do it You can start working on this, there should be nothing left to discuss lang: c++ Done in C++ code nice new thing ☺ A new feature that was not there before

Comments

@heinezen
Copy link
Member

heinezen commented Aug 25, 2024

Required Skills: C++ (understanding OpenGL terminology is helpful too)

Difficulty: Easy

Whenever we want to change something in the shader for an object, we use a UniformInput object to store the values. When the object is rendered, the data from the uniform input is passed to the GPU, e.g. via OpenGL. The definitions of the uniform data rypes are stored in the ShaderProgram class.

During rendering, the GPU does not strictly require that all uniform values have to be set for rendering to happen. However, when a uniform value is not set, e.g. when someone forgets to set pass it to the uniform input, this often leads to rendering errors, or worse: nothing being rendered at all. This is often infuriating to debug as it not always clear from the start whether the value was just forgotten or another error produces the rendering problems. To mitigate these issues, we should add a way to check if all uniform values for a uniform input have been set.

To try out the renderer and see how setting uniform values work, check out renderer demo 4 by running the following command:

./run test -d renderer.tests.renderer_demo 4

Tasks:

Further Reading

@heinezen heinezen added improvement Enhancement of an existing component area: renderer Concerns our graphics renderer nice new thing ☺ A new feature that was not there before lang: c++ Done in C++ code good first issue Suitable for newcomers just do it You can start working on this, there should be nothing left to discuss labels Aug 25, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in openage renderer Aug 25, 2024
@heinezen heinezen moved this to renderer in openage beginner tasks Aug 25, 2024
@heinezen heinezen pinned this issue Aug 25, 2024
@heinezen heinezen added the hacktoberfest For newcomers from Hacktoberfest event label Sep 20, 2024
@AdamYChe
Copy link

Hey, I think I'll try this issue out.

@heinezen
Copy link
Member Author

@AdamYChe Nice! If you have any problems, contact us in our chatroom

@yukirine
Copy link

Hey ! can i try this issue too ?

@heinezen
Copy link
Member Author

@yukirine Yes, you can!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: renderer Concerns our graphics renderer good first issue Suitable for newcomers hacktoberfest For newcomers from Hacktoberfest event improvement Enhancement of an existing component just do it You can start working on this, there should be nothing left to discuss lang: c++ Done in C++ code nice new thing ☺ A new feature that was not there before
Projects
Status: renderer
Status: 📋 Backlog
Development

No branches or pull requests

3 participants