Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOD COMPATIBILITY] CIT Textures don't display in item frames when using More Culling's Custom Item Frame Renderer #313

Open
KawaiiBakemono opened this issue Sep 2, 2023 · 4 comments
Labels
bug Something isn't working compatibility Explicit support for other mods

Comments

@KawaiiBakemono
Copy link

KawaiiBakemono commented Sep 2, 2023

Bug

When paired with the More Culling, any CIT texture, when placed in either type of item frame, displays the default item texture.

See bug replication here on YouTube.

Expected Result

The item should retain it's given CIT texture.

Info

Mod Version: 1.1.3
Minecraft Version: 1.20.1
Launcher: Prism Launcher 6.3
Mod Loader: Fabric 0.14.21
OS: Kubuntu Linux

@the-n1n
Copy link

the-n1n commented Sep 5, 2023

That looks like its Entity Culling's Item Frame renderer, I think you need to disable that.

@KawaiiBakemono
Copy link
Author

Dang you can tell what renderer it's using? And yes that was the issue, thank you! Should I have this under a compatibility issue instead?

@KawaiiBakemono KawaiiBakemono changed the title CIT Textures don't display when placed in item frames [MOD COMPATIBILITY] CIT Textures don't display when placed in item frames when using Entity Culling Sep 5, 2023
@KawaiiBakemono KawaiiBakemono changed the title [MOD COMPATIBILITY] CIT Textures don't display when placed in item frames when using Entity Culling [MOD COMPATIBILITY] CIT Textures don't display in item frames when using Entity Culling Sep 5, 2023
@KawaiiBakemono
Copy link
Author

KawaiiBakemono commented Sep 5, 2023

Okay, nevermind! I did some further testing and it seems I had both Entity Culling AND More Culling installed. In this case More Culling was the issue, not Entity Culling. I updated my pack to include instructions to bypass this, which is just a matter of disabling the Custom Item Frame Renderer. Sorry about that! I should've done more testing beforehand haha.

@KawaiiBakemono KawaiiBakemono changed the title [MOD COMPATIBILITY] CIT Textures don't display in item frames when using Entity Culling [MOD COMPATIBILITY] CIT Textures don't display in item frames when using More Culling's Custom Item Frame Renderer Sep 5, 2023
@Brancieq-Paul
Copy link

The problem here, the item frame renderer is one of the more important MC optimisations. I don't if it's possible, but it would be nice that CIT Resewn was compatible with the custom item frame renderer

@SHsuperCM SHsuperCM added bug Something isn't working compatibility Explicit support for other mods labels Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compatibility Explicit support for other mods
Projects
None yet
Development

No branches or pull requests

4 participants