Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrectly hardcoded column name for libraries #118

Open
jfy133 opened this issue May 12, 2023 · 2 comments
Open

Incorrectly hardcoded column name for libraries #118

jfy133 opened this issue May 12, 2023 · 2 comments
Labels
bug Something isn't working validate

Comments

@jfy133
Copy link
Member

jfy133 commented May 12, 2023

In libraries publication_doi is actually data_publication_doi but valdiate appears to check using teh samples column name

@jfy133 jfy133 added bug Something isn't working validate labels May 12, 2023
@maxibor
Copy link
Collaborator

maxibor commented Jun 1, 2023

The naming is inconsistent between library data_publication_doi and sample tables publication_doi, so maybe a change for AncientMetagenomeDir ?

@maxibor maxibor added the need upstream fix Need fix in dependancies label Jun 1, 2023
@jfy133
Copy link
Member Author

jfy133 commented Jun 2, 2023

It's like that on purposes, as in some cases the data (e.g. in single genome) is not from the exact same study as the original sample publication (e.g., a new group re-assemble a new apthogen from existing data - e.g. between Krause-Kyora and Lugli) - so it's important ti distinguish between the two.

@jfy133 jfy133 removed the need upstream fix Need fix in dependancies label Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working validate
Projects
None yet
Development

No branches or pull requests

2 participants