Code gets stuck in while loop, after module lost power

[niphiwi]

Hello,

I am using the 968-034 Digital Gas Sensor Module and recognized that the code gets stuck in this loop/function:

int DGS::getData(char c) {
[...]
  while (!_mySerial->available()) {
      }
[...]
}

This happens if the module loses power and gets reconnected to it again. By writing to the serial within the loop, I seem to have fixed this issue for me (see my fork of this repository):

int DGS::getData(char c) {
[...]
  while (!_mySerial->available()) {
        _mySerial->write(c);
      }
[...]
}

However, I am not sure, whether this is recommended or not...?

[dpeaslee]

Hello, Can I ask you to send your firmware version? You can retrieve by sending 'f' over uart.

…

On Mon, Aug 26, 2019 at 8:53 AM der-smu ***@***.***> wrote: Hello, I am using the 968-034 Digital Gas Sensor Module and recognized that the code gets stuck in this loop/function: int DGS::getData(char c) { [...] while (!_mySerial->available()) { } [...] } This happens if the module loses power and gets reconnected to it again. By writing to the serial within the loop, I seem to have fixed this issue for me (see my fork of this repository): int DGS::getData(char c) { [...] while (!_mySerial->available()) { _mySerial->write(c); } [...] } However, I am not sure, whether this is recommended or not...? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#4?email_source=notifications&email_token=AEKDMOI6KSJ6ISHSHFZTXYLQGPG3HA5CNFSM4IPPLBOKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HHL4NOA>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEKDMOJVBCYQBO4OAJDCQDTQGPG3HANCNFSM4IPPLBOA> .

[niphiwi]

Hi, the module returns '15SEP17'.

[dpeaslee]

Thank you, I'll look into the code, but please send a message when you can to [email protected]

…

On Tue, Aug 27, 2019 at 10:12 AM der-smu ***@***.***> wrote: Hi, the module returns '15SEP17'. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4?email_source=notifications&email_token=AEKDMOOE2EL4MRPFEMACBUTQGUY35A5CNFSM4IPPLBOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5H343I#issuecomment-525319789>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEKDMOP2BAALW5PJY573N2TQGUY35ANCNFSM4IPPLBOA> .