Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set danger for missing users/groups (fixes #22) #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eleanor-clifford
Copy link
Member

Not sure if danger should be True or False here, either fixes #22.

Copy link
Member

@rsa33 rsa33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if there's a better solution here than this Missing class, as it's still missing some other fields of Member and Society that will likely break other pages (e.g. the job details page).

For consideration:

  • Add a __getattr__ method which defaults to None for any attribute name?
  • Use dummy instances of Member/Society rather than passing in a duck-type placeholder?

Not sure if danger should be True or False here

True is probably the correct choice (meaning the job should be given some scrutiny before approval), though as this state requires having the corresponding account deleted there hopefully won't be any pending jobs for them...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'srcf.controllib.jobs.ChangeSocietyAdmin object' has no attribute 'has_danger'
2 participants