Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnail not loaded after connection loss #220

Open
defagos opened this issue Jun 10, 2020 · 0 comments
Open

Thumbnail not loaded after connection loss #220

defagos opened this issue Jun 10, 2020 · 0 comments

Comments

@defagos
Copy link
Member

defagos commented Jun 10, 2020

When attempting to play a fresh media (not a URN) with Letterbox without network, the view displays an error and no thumbnail (since none is available from the cache). If enabling the network, playback starts, but the thumbnail is never loaded.

This previously worked because we were performing many unnecessary periodic refreshes.

Maybe we can enable something for YYWebImage or force a reload ourselves. We could also consider other better options which might offer this feature (e.g. Nuke) or we could attempt to eliminate such dependencies by rolling our own simple solution.

Issue type

Incorrect behavior

Environment information

  • Library version: 5.0
  • iOS version: Any
  • Device: Any

Reproducibility

Always reproducible

Steps to reproduce

  1. Open LB demo for a 5.0 version with optional media support in the settings (e.g. Nightly 372+).
  2. Open the SRF AOD list.
  3. Enable airplane mode
  4. Tap on a media. The player displays an error and no thumbnail.
  5. Disable airplane mode. The media plays but the thumbnail is never loaded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant