Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segments incorrectly displayed for livestreams without DVR on tvOS #236

Open
defagos opened this issue Nov 23, 2020 · 2 comments
Open

Segments incorrectly displayed for livestreams without DVR on tvOS #236

defagos opened this issue Nov 23, 2020 · 2 comments

Comments

@defagos
Copy link
Member

defagos commented Nov 23, 2020

On Apple TV, the info panel incorrectly displays segments for SRF 1, for example

Issue type

Incorrect behavior

Environment information

  • Library version: Any
  • OS version: Any tvOS
  • Device: Any (Apple TV)

Reproducibility

Always reproducible

Steps to reproduce

  1. Play SRF 1 in Letterbox demo.
  2. Open the info panel.
defagos added a commit that referenced this issue Nov 23, 2020
@defagos
Copy link
Member Author

defagos commented Nov 23, 2020

Available for review on feature/live-segment-removal.

@defagos defagos added this to the 6.0.1 milestone Nov 23, 2020
defagos added a commit that referenced this issue Nov 23, 2020
@defagos defagos closed this as completed Nov 24, 2020
@defagos defagos reopened this Dec 7, 2020
@defagos defagos removed this from the 6.1.0 milestone Dec 7, 2020
@defagos
Copy link
Member Author

defagos commented Dec 7, 2020

The fix proposal was not working correctly, as it was making segments unreliably appear on on-demand content. The fix was therefore reverted.

The problem is related to the DVR window (zero for a livestream) which needs to be taken into account to display only segments within it. This theoretically requires observing timeRange updates (easy), but then reloading the panel (hard to do efficiently, as tvOS info panel does not update during playback). We have a reload mechanism in place, but it seems to be quite slow if done too frequently, and the current position in the info panel is lost.

The best way is probably to open an Apple bug report so that the info panel is properly updated when changes are detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant