Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Merging from forks is not working #191

Open
2 tasks
jernejk opened this issue Oct 27, 2023 · 0 comments 路 Fixed by #198
Open
2 tasks

馃悰 Merging from forks is not working #191

jernejk opened this issue Oct 27, 2023 · 0 comments 路 Fixed by #198
Labels
Type: Bug A problem with existing functionality

Comments

@jernejk
Copy link
Member

jernejk commented Oct 27, 2023

Cc: @GordonBeeming @danielmackay @Hona @william-liebenberg @wicksipedia

Hi team,

Describe the Bug

When creating a PR from a fork will always result in the build failing.

image
Figure: Build will always fail on this step.

There is nothing the author of the PR can do to fix this issue. It's a security issue that prevents the build from ever passing.

To Reproduce

Steps to reproduce the behaviour:

  1. Create a fork
  2. Make any change (even a Markdown file)
  3. Create PR into this repository
  4. See the build fail

Expected Behavior

External people should be able to give mergeable PRs to SSW.CleanArchitecture for improvements and suggestions.

PS: Can avoid this in the future so that it is easier to contribute to SSW projects?

Tasks

  • Investigate
  • Update test or variables so that PRs from forks can work

Screenshots

image
Figure: Changed just a markdown that would not impact the build and yet it fails.

image
Figure: Only Markdown was changed.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug A problem with existing functionality
Projects
1 participant