Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inform Identity not called upon receipt of NAK response #7

Open
DanLiemanGalvion opened this issue Feb 12, 2025 · 3 comments
Open

Inform Identity not called upon receipt of NAK response #7

DanLiemanGalvion opened this issue Feb 12, 2025 · 3 comments
Assignees
Labels
enhancement New feature or request internal bug tracker Issue confirmed and reported into a ticket in the internal bug tracking system mw MW-related issue or pull-request usb-pd USB Power-Delivery-related issue or pull-request

Comments

@DanLiemanGalvion
Copy link

void (*USBPD_VDM_InformIdentity)(uint8_t PortNum, USBPD_SOPType_TypeDef SOPType,
USBPD_VDM_CommandType_Typedef CommandStatus,
USBPD_DiscoveryIdentity_TypeDef *pIdentity);

in USBPD_VDM_Callbacks is not called on receipt of a NAK response even though USBPD_VDM_CommandType_Typedef has a SVDM_RESPONDER_NAK define. This may affect other VDM Inform callbacks, but I have not had the chance to verify.

A workaround similar to that documented in #4 is likely possible since the NAK response is also at the end of the AMS(Atomic Message Sequence)

@DanLiemanGalvion
Copy link
Author

Workaround for this issue posted #4 (comment)

@ALABSTM ALABSTM self-assigned this Feb 13, 2025
@ALABSTM ALABSTM added enhancement New feature or request mw MW-related issue or pull-request usb-pd USB Power-Delivery-related issue or pull-request labels Feb 13, 2025
@ALABSTM ALABSTM moved this from To do to Analyzed in stm32cube-mcu-mw-dashboard Feb 17, 2025
@ALABSTM ALABSTM added the internal bug tracker Issue confirmed and reported into a ticket in the internal bug tracking system label Feb 17, 2025
@ALABSTM
Copy link

ALABSTM commented Feb 17, 2025

ST Internal Reference: 203379

@DanLiemanGalvion
Copy link
Author

I will note that section 8.3.3.22.1 (Initiator Structured VDM Discover Identity State Diagram) in USBPD standard Revision 3.2, V1.1, and
8.3.3.22.1 (Initiator Structured VDM Discover Identity State Diagram) in Revision 3.1, V.15 (I don't have access to Revision 3.1, V1.7 which this library conforms to) does specify that the policy engine shall inform the Device Policy Manager of the result in the case of Discover Identity NAK/BUSY or VDMResponseTimer Timeout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internal bug tracker Issue confirmed and reported into a ticket in the internal bug tracking system mw MW-related issue or pull-request usb-pd USB Power-Delivery-related issue or pull-request
Projects
Development

No branches or pull requests

2 participants