Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system token header to query SCC subscriptions (bsc#1219855) #88

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

dirkmueller
Copy link
Member

@dirkmueller dirkmueller commented Feb 26, 2024

when a system was cloned, SCC falls back to the first system ever registered for determining subscriptions. passing in the system token should help with that.

@dirkmueller dirkmueller changed the title Add system token Add system token header to query SCC subscriptions (bsc#1219855) Feb 26, 2024
when a system was cloned, SCC falls back to the first system ever
registered for determining subscriptions. passing in the system
token should help with that.
@dcermak dcermak merged commit a93022d into SUSE:master Feb 28, 2024
1 check passed
@digitaltom
Copy link
Member

Sorry, I'm a bit late in the game here, but it's important that when authenticating including the system token, to also write back the new token of the response to the credentials file. Else the next API request will use an outdated token and trigger a system duplication on the server.

@dcermak
Copy link
Collaborator

dcermak commented Mar 18, 2024

Sorry, I'm a bit late in the game here, but it's important that when authenticating including the system token, to also write back the new token of the response to the credentials file. Else the next API request will use an outdated token and trigger a system duplication on the server.

That's not possible from container-suseconnect, as it cannot write to the host's credentials file.

@dirkmueller shall we revert this then?

@dirkmueller
Copy link
Member Author

@dirkmueller shall we revert this then?

No, the change is needed. we're going to change SCC instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants