Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove static from klpp_ functions and add them to header file #12

Open
lhruska opened this issue Jul 30, 2024 · 3 comments
Open

remove static from klpp_ functions and add them to header file #12

lhruska opened this issue Jul 30, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@lhruska
Copy link
Collaborator

lhruska commented Jul 30, 2024

ccp always sets the LPed functions (klpp_ prefix) as static. The static keyword then be manually removed, and all those functions must also be added to the livepatch_xxx.h header file.
Automating this would save a lot of time and nerves.

@lhruska lhruska added the enhancement New feature or request label Jul 30, 2024
@marcosps
Copy link
Collaborator

This is already done by clang-extract, and unfortunately klp-ccp doesn't...

@lhruska
Copy link
Collaborator Author

lhruska commented Jul 30, 2024

I know, but it can be fixed after running the klp-ccp by a few (hopefully) simple regexes. I will try to fix it.

@marcosps
Copy link
Collaborator

Removing the static keyword from klpp functions would help us to match the expected behavior between cp and ce (we have issues about dead-code-elimination on ce and we spend quite sometime before realizing that removing the statis keyword would make it reproducible on ccp as well).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants