Add mkdir command when using --junit #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add mkdir command to create the report folder later used by ansible-playbook to store junit reports.
hadeskun
reviewed
Oct 9, 2024
| @@ -281,6 +281,16 @@ def ansible_command_sequence(configure_data_ansible, base_project, sequence, ver | |||
| # 4. Start composing and accumulating the list of all needed commands | |||
| ansible_cmd = [] | |||
| ansible_cmd_seq = [] | |||
|
|
|||
| if junit and not os.path.isdir(junit): | |||
There was a problem hiding this comment.
I would write like this to be more readable:
`junit_specified = bool(junit)
junit_is_not_dir = not path.isdir(junit)
if junit_specified and junit_is_not_dir:`
There was a problem hiding this comment.
I prefer the more concise syntax here, but it is a matter of teste I think. So I'll wait other reviewers before to decide.
There was a problem hiding this comment.
For me it looks good but as you said it's a preference
jankohoutek
reviewed
Oct 9, 2024
scripts/qesap/lib/cmds.py
Outdated
| # the folder is not created. | ||
| # Create an empty folder in advance, if it is not already there | ||
| # so that the glue script called can always suppose that at least the folder is present. | ||
| ansible_cmd_seq.append({'cmd': ['mkdir', junit]}) |
There was a problem hiding this comment.
Maybe add -p to the mkdir command:
-p, --parents no error if existing, make parent directories as needed
alvarocarvajald
approved these changes
Oct 9, 2024
| if junit and not os.path.isdir(junit): | ||
| # This is the folder also used in the Ansible configuration JUNIT_OUTPUT_DIR. | ||
| # ansible-playbook is able to create it from its own but | ||
| # is a failure occur in the first sequence command, that is ansible and not ansible-playbook, |
There was a problem hiding this comment.
s/is a failure occur/if a failure occurs/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mkdir command to create the report folder later used by ansible-playbook to store junit reports.
Ticket: https://jira.suse.com/browse/TEAM-9713
Verification
mkdiris visible at the beginning of http://openqaworker15.qa.suse.cz/tests/299484/logfile?filename=deploy-qesap_exec_ansible.log.txt