Fix azure sbd stonith-timeout and add concurrent-fencing #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankohoutek
suggested changes
Nov 8, 2024
BillAnastasiadis
force-pushed
the
fence_time
branch
from
2428605 to
3a41d6e
Compare
BillAnastasiadis
changed the title
mpagot
reviewed
Nov 11, 2024
BillAnastasiadis
force-pushed
the
fence_time
branch
from
3a41d6e to
fa9a362
Compare
BillAnastasiadis
force-pushed
the
fence_time
branch
from
fa9a362 to
b54faed
Compare
mpagot
changed the title
BillAnastasiadis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered by @jankohoutek , stonith-timeout was set erroneously for both azure sbd and native fencing cases. This pr attempts to fix that.
This pr also enables concurrent fencing, as suggested in https://learn.microsoft.com/en-us/azure/sap/workloads/high-availability-guide-suse-pacemaker?tabs=msi#create-a-fencing-device-on-the-pacemaker-cluster
Verification Runs:
SBD:
https://openqa.suse.de/tests/15879961 PASS
https://openqa.suse.de/tests/15882210 PASS
https://openqa.suse.de/tests/15882212 PASS
https://openqa.suse.de/tests/15882213 PASS
MSI:
https://openqa.suse.de/tests/15879960 PASS
https://openqa.suse.de/tests/15882208 PASS
https://openqa.suse.de/tests/15882209 FAIL (crash site A)
https://openqa.suse.de/tests/15882211 PASS
SPN:
https://openqa.suse.de/tests/15882224 FAIL (crash site A)
https://openqa.suse.de/tests/15882225 PASS
https://openqa.suse.de/tests/15882226 FAIL (kill site A - primary)
https://openqa.suse.de/tests/15892130 PASS
VRs for the concurrent fencing:
PASS (23):
https://openqa.suse.de/tests/15893608
https://openqa.suse.de/tests/15893612 (failed for irrelevant reason at the end)
https://openqa.suse.de/tests/15893618
https://openqa.suse.de/tests/15894470
https://openqa.suse.de/tests/15894472
https://openqa.suse.de/tests/15894494
https://openqa.suse.de/tests/15894495
https://openqa.suse.de/tests/15894496
https://openqa.suse.de/tests/15894765
https://openqa.suse.de/tests/15894834
https://openqa.suse.de/tests/15894768
https://openqa.suse.de/tests/15894770
https://openqa.suse.de/tests/15894771
https://openqa.suse.de/tests/15894772
https://openqa.suse.de/tests/15894767
https://openqa.suse.de/tests/15895221
https://openqa.suse.de/tests/15895222
https://openqa.suse.de/tests/15895479
https://openqa.suse.de/tests/15895480
https://openqa.suse.de/tests/15895481
https://openqa.suse.de/tests/15895483
https://openqa.suse.de/tests/15898297
https://openqa.suse.de/tests/15898327
https://openqa.suse.de/tests/15898791
https://openqa.suse.de/tests/15898792
https://openqa.suse.de/tests/15898793
FAIL (1) at
crash_replicadue to ssh issues:https://openqa.suse.de/tests/15895479