Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move error handling to the proper method #1235

Merged
merged 8 commits into from
Nov 7, 2024
Merged

Move error handling to the proper method #1235

merged 8 commits into from
Nov 7, 2024

Commits on Oct 3, 2024

  1. Move error handling to the proper method 

    The method that gets the activations from SCC by making a request,
should be responsible to handle if the request failed

Use Rails.logger instead of carrying logger all over the methods
    @jesusbv
    jesusbv committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    d00aa5e View commit details
    Browse the repository at this point in the history

  2. Remove the logger param from the methods because of the Rails.logger … 

    …change
    @jesusbv
    jesusbv committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    78ab205 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Merge branch 'master' into sccproxy-activations-error-handling

    @digitaltom
    digitaltom authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    8be136b View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Use system object 

    Instead of passing system attributes, send system itself
and use its attributes inside
    @jesusbv
    jesusbv committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    6a47425 View commit details
    Browse the repository at this point in the history

  2. Remove unnecesary disabling rule

    @jesusbv
    jesusbv committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    ed98758 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Merge branch 'master' into sccproxy-activations-error-handling

    @jesusbv
    jesusbv authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    9a33df8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into sccproxy-activations-error-handling

    @jesusbv
    jesusbv authored Nov 6, 2024
    Configuration menu
    Copy the full SHA
    e50c470 View commit details
    Browse the repository at this point in the history

  3. Adjust after merging master branch and solve conflicts

    @jesusbv
    jesusbv committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    09e876b View commit details
    Browse the repository at this point in the history